Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #3067

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Allow Symfony 7 #3067

merged 1 commit into from
Jun 24, 2024

Conversation

simoheinonen
Copy link

@@ -26,6 +26,12 @@ jobs:
- description: 'Symfony 5.*'
php: '8.1'
symfony-versions: '^5.4'
- description: 'Symfony 6.*'
php: '8.1'
symfony-versions: '^6.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LTS is 6.4, not 6.3

symfony-versions: '^6.3'
- description: 'Symfony 7.*'
php: '8.2'
symfony-versions: '^7.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job should be removed as we don't have a LTS version of Symfony 7 yet anyway. Symfony 7 will already be tested in the normal job for PHP 8.2 as that will be the compatible version.

Model/User.php Outdated
* @return void
*/
public function eraseCredentials()
public function eraseCredentials(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a BC break for child classes. If this is required to support Symfony 7, it means we will have to release it as a new major version (in which case we might want to first do a new minor version to ensure that we have the appropriate @return everywhere so that our new major version can switch to native return types everywhere)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you added the return types in #3069 but never released it. Can you do that?

Should I go ahead and add the native return types in this PR and then we could get new major version out or should that be separate PR?

@deadbublik
Copy link

Hi guys! Thank you for your work!
Do you have any updates on this issue?

@cbeyer
Copy link

cbeyer commented Jun 21, 2024

Hi, any news for Symfony 7 compatibility ?

@stof stof merged commit 095260b into FriendsOfSymfony:master Jun 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Symfony 7
4 participants